Skip to content

fix(qt): move labelError styling from proposalcreate.ui into general.css#7145

Open
UdjinM6 wants to merge 1 commit intodashpay:developfrom
UdjinM6:fix_propcrecss
Open

fix(qt): move labelError styling from proposalcreate.ui into general.css#7145
UdjinM6 wants to merge 1 commit intodashpay:developfrom
UdjinM6:fix_propcrecss

Conversation

@UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Feb 15, 2026

Issue being fixed or feature implemented

labelError styling is in the wrong place, it's a translatable string (missed notr="true") and... it is not actually working at all 🤷‍♂️

develop this PR
Screenshot 2026-02-14 at 00 27 44 Screenshot 2026-02-14 at 00 29 24

Discovered thanks to a broken translation found by @coderabbitai #7141 (comment)

What was done?

Move labelError styling from proposalcreate.ui into general.css. Will be dropped from *.ts files in some future Translations PR.

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@github-actions
Copy link

This pull request has conflicts, please rebase.

@github-actions
Copy link

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

@coderabbitai
Copy link

coderabbitai bot commented Feb 15, 2026

Walkthrough

This change relocates the margin-left: 8px styling for the labelError element from an inline styleSheet property in the UI form file to an external CSS stylesheet. The styling definition is moved from src/qt/forms/proposalcreate.ui to a new ProposalCreate section in src/qt/res/css/general.css, consolidating style definitions in a dedicated stylesheet rather than embedding them within the UI layout file.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: moving labelError styling from proposalcreate.ui to general.css, which matches the changeset exactly.
Description check ✅ Passed The description is directly related to the changeset, explaining the issue, the solution, and providing visual evidence of the problem being fixed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into develop

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@UdjinM6 UdjinM6 added this to the 23.1.1 milestone Feb 15, 2026
Copy link
Collaborator

@kwvg kwvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK bc779c6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants