fix(qt): move labelError styling from proposalcreate.ui into general.css#7145
fix(qt): move labelError styling from proposalcreate.ui into general.css#7145UdjinM6 wants to merge 1 commit intodashpay:developfrom
Conversation
|
This pull request has conflicts, please rebase. |
✅ No Merge Conflicts DetectedThis PR currently has no conflicts with other open PRs. |
WalkthroughThis change relocates the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Issue being fixed or feature implemented
labelErrorstyling is in the wrong place, it's a translatable string (missednotr="true") and... it is not actually working at all 🤷♂️Discovered thanks to a broken translation found by @coderabbitai #7141 (comment)
What was done?
Move
labelErrorstyling fromproposalcreate.uiintogeneral.css. Will be dropped from*.tsfiles in some future Translations PR.How Has This Been Tested?
Breaking Changes
Checklist: