Skip to content

Conversation

@artur-ciocanu
Copy link
Contributor

Description

Renaming streaming subscription to "subscribeToTopic". This should align better with other Dapr SDKs and ensure that is more ergonomic.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: N/A

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
@artur-ciocanu artur-ciocanu requested review from a team as code owners January 25, 2026 06:34
@codecov
Copy link

codecov bot commented Jan 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.93%. Comparing base (d759c53) to head (829f85b).
⚠️ Report is 251 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1626      +/-   ##
============================================
+ Coverage     76.91%   78.93%   +2.02%     
- Complexity     1592     2083     +491     
============================================
  Files           145      227      +82     
  Lines          4843     6277    +1434     
  Branches        562      692     +130     
============================================
+ Hits           3725     4955    +1230     
- Misses          821      970     +149     
- Partials        297      352      +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@artur-ciocanu
Copy link
Contributor Author

@dapr/approvers-java-sdk and @dapr/maintainers-java-sdk could you please take a look. I think this should be the final name for streaming subscription and it aligns with other SDKs nicely.

@alicejgibbons could you also please take a look.

Thank you 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant