Skip to content

fix(ci): trigger CLI build after creating release tag #1626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nelson-parente wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(ci): trigger CLI build after creating release tag #1626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ad4e13
fix(ci): trigger CLI build after creating release tag
nelson-parente Apr 9, 2026
44891ad
fix(ci): add workflow_dispatch trigger to dapr_cli.yaml
nelson-parente Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions .github/workflows/create-release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ on:
inputs:
rel_version:
description: 'Release version (examples: 1.16.0-rc.1, 1.16.0)'
required: true
required: true
type: string

permissions: {}
Expand Down Expand Up @@ -46,4 +46,17 @@ jobs:
git config user.name "Dapr Bot"
# Update origin with token
git remote set-url origin https://x-access-token:${GITHUB_TOKEN}@github.com/${GITHUB_REPOSITORY}.git
./.github/scripts/create-release.sh ${{ inputs.rel_version }}
./.github/scripts/create-release.sh ${{ inputs.rel_version }}

trigger:
name: Triggers the CLI build
runs-on: ubuntu-latest
needs: create-release
permissions:
actions: write
steps:
- name: Triggers the build
env:
GITHUB_TOKEN: ${{ secrets.DAPR_BOT_TOKEN }}
run: |
gh workflow run dapr_cli.yaml --repo dapr/cli --ref v$(echo '${{ inputs.rel_version }}' | sed -r 's/^[vV]?([0-9].+)$/\1/')
Copy link
Copy Markdown
Member

@acroca acroca Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be better to use the workflow_call approach instead.
When using workflow_call in the target workflow, we can invoke it with uses: ./.github/workflows/dapr_cli.yml, and it runs the workflow as part of the current workflow, so if the dapr_cli workflow fails, the release workflow will also show red.

Maybe we prefer to keep it consistent with dapr/dapr, but I think the workflow_call approach is better in this case.

1 change: 1 addition & 0 deletions .github/workflows/dapr_cli.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
name: dapr_cli

on:
workflow_dispatch:
push:
branches:
- master
Expand Down
Loading