vim: fix highlighting #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Acknowledging I see your PR! Will take a look tomorrow |
gcanat
commented
May 21, 2025
danobi
reviewed
May 22, 2025
Owner
danobi
left a comment
danobi
left a comment
There was a problem hiding this comment.
I'm no vimscript expert (or even beginner), but I tested this and it looks correct. Nice to be able to simplify the region specific logic.
Just one nit.
vim/ftplugin/prr.vim
Outdated
|
|
||
| let b:undo_ftplugin = 'setl fdm&' | ||
| " Adapted from https://github.com/sgeb/vim-diff-fold | ||
| function! DiffFoldLevel() |
Owner
There was a problem hiding this comment.
Should be able to make this script local, right?
Suggested change
| function! DiffFoldLevel() | |
| function! s:DiffFoldLevel() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into some highlighting issues as shown in this demo.
I was able to fix it by replacing
foldmethod=syntaxwithfoldmethod=exprwhich allowed me to remove thesyn regiondefinitions in the syntax file.The fold function is adapted from vim-diff-fold
I took the liberty to make some
syn matcha bit more restrictive and also changed the highlight groups forprrAddedandprrRemovedto the standard diff groups which feels more natural when going through diffs.Happy to discuss any modifications or improvement.
And thanks for this cool tool 😃