Skip to content

fix #14352: fuzzing crash (null-pointer-use) in Preprocessor::simplifyPragmaAsmPrivate() #8075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ludviggunne wants to merge 3 commits into
base: main
Choose a base branch
from
+19 −2
Open

fix #14352: fuzzing crash (null-pointer-use) in Preprocessor::simplifyPragmaAsmPrivate() #8075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07093ce
add crash file
ludviggunne Dec 31, 2025
5b0f9e5
add test
ludviggunne Dec 31, 2025
9a77b3a
fix #14352
ludviggunne Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions lib/preprocessor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1072,11 +1072,19 @@ void Preprocessor::simplifyPragmaAsmPrivate(simplecpp::TokenList &tokenList)
break;
}

const simplecpp::Token * const tok4 = tok3->next;
tok->setstr("asm");
const_cast<simplecpp::Token *>(tok2)->setstr("(");
const_cast<simplecpp::Token *>(tok3)->setstr(")");
const_cast<simplecpp::Token *>(tok4)->setstr(";");

simplecpp::Token * tok4;
if (tok3->next) {
tok4 = tok3->next;
tok4->setstr(";");
} else {
tok4 = new simplecpp::Token(";", tok3->location);
const_cast<simplecpp::Token *>(tok3)->next = tok4;
}

while (tok4->next != endasm)
tokenList.deleteToken(tok4->next);
}
Expand Down
1 change: 1 addition & 0 deletions test/cli/fuzz-crash/crash-ef635709a2489083534cd422e6a089daab23ec64
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
#pragma asm
8 changes: 8 additions & 0 deletions test/testpreprocessor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,8 @@ class TestPreprocessor : public TestFixture {
TEST_CASE(standard);

TEST_CASE(writeLocations);

TEST_CASE(pragmaAsm);
}

template<size_t size>
Expand Down Expand Up @@ -2773,6 +2775,12 @@ class TestPreprocessor : public TestFixture {
"} ;",
processed);
}

void pragmaAsm()
{
const char code[] = "#pragma asm";
(void) getcodeforcfg(settingsDefault, *this, code, "", "test.cpp");
}
};

REGISTER_TEST(TestPreprocessor)
Loading