Skip to content

re-run analysis in Python tests with cached results when TEST_CPPCHECK_INJECT_BUILDDIR is specified #7079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
firewave wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

re-run analysis in Python tests with cached results when TEST_CPPCHECK_INJECT_BUILDDIR is specified #7079

firewave wants to merge 10 commits into from
+108 −2,377

Conversation

@firewave
Copy link
Collaborator

@firewave firewave commented Dec 7, 2024

No description provided.

firewave
firewave commented Dec 7, 2024
View reviewed changes
test/cli/testutils.py
print(stderr_lines)
print('stderr - actual')
print(stderr_1_lines)
# TODO: filter out checkersReport because it different amount of active checkers for cached runs
Copy link
Collaborator Author

@firewave firewave Dec 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I filed https://trac.cppcheck.net/ticket/13388 about this.

@firewave
Copy link
Collaborator Author

firewave commented Dec 7, 2024

The difference in the output of test_invalid_addon_py_verbose is tracked in https://trac.cppcheck.net/ticket/13389.

firewave
firewave commented Dec 7, 2024
View reviewed changes
test/cli/testutils.py
# strip some common output only seen during analysis
stdout_lines = [entry for entry in stdout_lines if not entry.startswith('Processing rule: ')]
stdout_lines = [entry for entry in stdout_lines if not entry.startswith('progress: ')]
# TODO: no messages for checked configurations when using cached data
Copy link
Collaborator Author

@firewave firewave Dec 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I filed https://trac.cppcheck.net/ticket/13390 about this.

@firewave
Copy link
Collaborator Author

firewave commented Dec 7, 2024 •
edited
Loading

test/cli/helloworld_test.py::test_sarif - https://trac.cppcheck.net/ticket/13393 (Windows only)
test/cli/helloworld_test.py::test_xml_checkers_report - https://trac.cppcheck.net/ticket/13388 / https://trac.cppcheck.net/ticket/13390 (not fixed but test passes)
test/cli/inline-suppress_test.py::test_unmatched_cfg - https://trac.cppcheck.net/ticket/13087
test/cli/inline-suppress_test.py::test_unmatched_suppression
test/cli/inline-suppress_test.py::test_unmatched_suppression_path_with_extra_stuff
test/cli/inline-suppress_test.py::test_unused_function_disabled_unmatched - https://trac.cppcheck.net/ticket/13087
test/cli/inline-suppress_test.py::test_xml - https://trac.cppcheck.net/ticket/13388
test/cli/inline-suppress_test.py::test_unused_function_unmatched - https://trac.cppcheck.net/ticket/13087
test/cli/metrics_test.py::test_dummy_metrics_stdout
test/cli/metrics_test.py::test_dummy_metrics_xml_report
test/cli/other_test.py::test_execute_addon_file0- https://trac.cppcheck.net/ticket/13391
test/cli/other_test.py::test_addon_namingng_config - https://trac.cppcheck.net/ticket/13389 (mitigated but not properly fixed)
test/cli/other_test.py::test_checkers_report_misra_json - https://trac.cppcheck.net/ticket/13388
test/cli/other_test.py::test_inline_suppr - https://trac.cppcheck.net/ticket/13087
test/cli/other_test.py::test_inline_suppr_j - https://trac.cppcheck.net/ticket/13087
test/cli/other_test.py::test_invalid_addon_py_verbose - https://trac.cppcheck.net/ticket/13389 (mitigated but not properly fixed)
test/cli/other_test.py::test_suppress_unmatched_wildcard
test/cli/premium_test.py::test_misra_c_builtin_style_check - https://trac.cppcheck.net/ticket/13388
test/cli/inline-suppress_test.py::test_misra_disabled_unmatched - https://trac.cppcheck.net/ticket/13087
test/cli/inline-suppress_test.py::test_premium_disabled_unmatched - https://trac.cppcheck.net/ticket/13087
test/cli/proj2_test.py::test_gui_project_loads_relative_vs_solution_2 - https://trac.cppcheck.net/ticket/13926
test/cli/proj2_test.py::test_gui_project_loads_relative_vs_solution_with_exclude - https://trac.cppcheck.net/ticket/13926
test/cli/proj2_test.py::test_gui_project_loads_absolute_vs_solution_2 - https://trac.cppcheck.net/ticket/13926
test/cli/suppress-syntaxError_test.py::test_safety_suppress_syntax_error_explicitly
test/cli/suppress-syntaxError_test.py::test_safety_suppress_syntax_error_implicitly
test/cli/whole-program_test.py::test_addon_suppress_inline
test/cli/whole-program_test.py::test_addon_suppress_inline_project
test/cli/whole-program_test.py::test_nullpointer_file0 - https://trac.cppcheck.net/ticket/13906 (Windows only) (still appears to happen)

@firewave firewave force-pushed the inject-builddir-verify branch from 3157251 to 65f313c Compare January 2, 2025 20:06
@firewave firewave mentioned this pull request Jan 4, 2025
Merged
@firewave firewave mentioned this pull request Feb 3, 2025
Open
@firewave firewave force-pushed the inject-builddir-verify branch from 65f313c to 7a6ae00 Compare February 6, 2025 12:24
@firewave firewave force-pushed the inject-builddir-verify branch 4 times, most recently from 1a5a092 to b99f311 Compare June 2, 2025 17:52
@firewave firewave mentioned this pull request Jun 2, 2025
Merged
@firewave firewave force-pushed the inject-builddir-verify branch from b99f311 to 23f112f Compare June 10, 2025 10:41
@firewave firewave mentioned this pull request Jun 29, 2025
Open
@firewave firewave mentioned this pull request Aug 18, 2025
Merged
@firewave firewave force-pushed the inject-builddir-verify branch 2 times, most recently from bea8b24 to 66157c8 Compare September 9, 2025 12:47
@firewave firewave mentioned this pull request Sep 9, 2025
Merged
@firewave firewave force-pushed the inject-builddir-verify branch from 66157c8 to 21a9871 Compare September 25, 2025 07:08
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 25, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@firewave firewave mentioned this pull request Sep 25, 2025
Merged
@firewave firewave force-pushed the inject-builddir-verify branch from 21a9871 to 3eacde7 Compare November 1, 2025 17:22
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 1, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@firewave firewave force-pushed the inject-builddir-verify branch from 3eacde7 to 73e1b82 Compare January 3, 2026 11:06
@firewave firewave force-pushed the inject-builddir-verify branch from 8a3165a to 9dc6fc9 Compare January 4, 2026 03:57
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 4, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@firewave