Skip to content

fix(core): prevent duplicate setInterval in dispatchEvent #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ENvironmentSet merged 2 commits into from
Mar 12, 2026
Merged

fix(core): prevent duplicate setInterval in dispatchEvent #683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d6334d
fix(core): prevent duplicate setInterval in dispatchEvent
ENvironmentSet Mar 11, 2026
e723f02
fix(core): use currentInterval guard instead of intervalRunning flag
ENvironmentSet Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-duplicate-interval.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@stackflow/core": patch
---

fix(core): prevent duplicate setInterval in dispatchEvent
10 changes: 10 additions & 0 deletions core/src/makeCoreStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,8 @@ export function makeCoreStore(options: MakeCoreStoreOptions): CoreStore {
value: aggregate(events.value, new Date().getTime()),
};

let currentInterval: ReturnType<typeof setInterval> | null = null;

const actions: StackflowActions = {
getStack() {
return stack.value;
Expand All @@ -98,6 +100,10 @@ export function makeCoreStore(options: MakeCoreStoreOptions): CoreStore {
events.value.push(newEvent);
setStackValue(nextStackValue);

if (currentInterval !== null) {
clearInterval(currentInterval);
}

const interval = setInterval(() => {
const nextStackValue = aggregate(events.value, new Date().getTime());

Expand All @@ -107,8 +113,12 @@ export function makeCoreStore(options: MakeCoreStoreOptions): CoreStore {

if (nextStackValue.globalTransitionState === "idle") {
clearInterval(interval);
if (currentInterval === interval) {
currentInterval = null;
}
}
}, INTERVAL_MS);
currentInterval = interval;
},
push: () => {},
replace: () => {},
Expand Down
Loading