Skip to content

[WIP] plugin-blocker#682

Draft
ENvironmentSet wants to merge 20 commits intomainfrom
add-plugin-blocker
Draft

[WIP] plugin-blocker#682
ENvironmentSet wants to merge 20 commits intomainfrom
add-plugin-blocker

Conversation

@ENvironmentSet
Copy link
Collaborator

TBD

ENvironmentSet and others added 9 commits March 10, 2026 16:27
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…brary

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Rewrite blockerPlugin to match the tech spec: no-arg blockerPlugin(),
useBlocker hook with shouldBlock/onBlocked/bypass, and supporting
NavigationEvent/BlockedNavigation types. Implementations are stubs.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Introduce a comprehensive technical specification document for the blockerPlugin, detailing the background, problem definition, design direction, public API, and usage examples. This document aims to unify the implementation of screen exit prevention across various mobile webview-based services.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2026

⚠️ No Changeset found

Latest commit: 199b356

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Mar 10, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7648a130-fb2f-4842-beec-09943a93dabd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch add-plugin-blocker
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use oxc to improve the quality of JavaScript and TypeScript code reviews.

Add a configuration file to your project to customize how CodeRabbit runs oxc.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 10, 2026

  • @stackflow/demo

    yarn add https://pkg.pr.new/daangn/stackflow/@stackflow/plugin-blocker@682.tgz
    

commit: 956f60e

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 10, 2026

Deploying stackflow-demo with  Cloudflare Pages  Cloudflare Pages

Latest commit: 199b356
Status:🚫  Build failed.

View logs

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 10, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
❌ Deployment failed
View logs
stackflow-docs 199b356 Mar 13 2026, 06:14 AM

ENvironmentSet and others added 9 commits March 11, 2026 00:28
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ride(fn) API

bypass was tied to replaying a specific BlockedNavigation object.
override(fn) wraps arbitrary navigation in a callback, making the
blocker skip check scoped to the callback's synchronous execution.
This gives developers a unified, general-purpose way to bypass
a blocker for any navigation — not just a previously blocked one.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant