fix(game-store): guard against splice(-1) in processScuttle#1336
Merged
itsalaidbacklife merged 2 commits intomainfrom Feb 13, 2026
Merged
fix(game-store): guard against splice(-1) in processScuttle#1336itsalaidbacklife merged 2 commits intomainfrom
itsalaidbacklife merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents hand corruption in the client game store by guarding against splice(-1, 1) when a scuttle event arrives and the played card is already missing from local state (e.g., socket event race/out-of-order delivery).
Changes:
- Add a
playedCardIndex === -1guard inprocessScuttle()to avoid removing the wrong card from hand. - Fall back to
updateGame(game)when local state is missing the played card, matching the existingtargetCardIndexguard behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
24422c8 to
07513da
Compare
itsalaidbacklife
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found during a code audit.
processScuttle()checkstargetCardIndex === -1before splicing but doesn't checkplayedCardIndex. If socket events arrive out of order and the played card is already missing from local state,splice(-1, 1)silently removes the last card in hand instead.Added the same
-1guard that already exists fortargetCardIndex.Issue number
Please check the following
Please describe additional details for testing this change
npm run test:unittargetCardIndexright above it