fix(GameView): prevent double API call in playOneOff during seven resolution#1335
Merged
itsalaidbacklife merged 2 commits intomainfrom Feb 12, 2026
Merged
fix(GameView): prevent double API call in playOneOff during seven resolution#1335itsalaidbacklife merged 2 commits intomainfrom
itsalaidbacklife merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a gameplay bug in GameView.vue where playOneOff() could trigger two API calls during seven resolution due to falling through from the seven-resolution path into the normal one-off path.
Changes:
- Add an early
returnafterrequestPlayOneOffSeven()to prevent fall-through intorequestPlayOneOff()when resolving a seven.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
itsalaidbacklife
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found during a code audit.
playOneOff()has two sequentialifblocks instead ofif/else. When resolving a seven, if bothcardSelectedFromDeckandselectedCardare set, bothrequestPlayOneOffSeven()ANDrequestPlayOneOff()fire. Two API calls for one user action.Added an early
returnafter the seven-resolution path so it never falls through to the normal one-off path.Issue number
Please check the following
Please describe additional details for testing this change
npm run test:unit