fix(rematch): move game variable from module scope to function scope#1334
Merged
itsalaidbacklife merged 2 commits intomainfrom Feb 13, 2026
Merged
fix(rematch): move game variable from module scope to function scope#1334itsalaidbacklife merged 2 commits intomainfrom
itsalaidbacklife merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a concurrency/race condition in the rematch controller by ensuring request-specific game state is not shared across concurrent requests.
Changes:
- Moved
let gamefrom module scope into the exported request handler scope to prevent cross-request state sharing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
itsalaidbacklife
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found during a code audit for the gpu stuff.
let gameis declared at module scope in the rematch controller, meaning all concurrent requests share the same variable. If two players hit rematch at the same time, the second request overwritesgamewhile the first is still using it.Fix is just moving the declaration inside the function.
Issue number
Please check the following
Please describe additional details for testing this change
npm run test:unit