Skip to content

Comments

chore: replace console logging with proper error handling#1333

Merged
itsalaidbacklife merged 4 commits intomainfrom
chore/replace-console-logging
Feb 18, 2026
Merged

chore: replace console logging with proper error handling#1333
itsalaidbacklife merged 4 commits intomainfrom
chore/replace-console-logging

Conversation

@seriouslysean
Copy link
Collaborator

@seriouslysean seriouslysean commented Feb 8, 2026

Cleaned up console.log/console.error calls across the codebase. Replaced them with console.warn for a more appropriate log level — these aren't fatal errors, but we still want visibility during development and in production.

Backend console.error in generate-secret.js swapped to sails.log.error so it respects the log level config.

Left src/util/audio.js alone since that warn is useful for debugging audio issues locally.

Issue number

  • N/A (found during code audit)

Please check the following

  • Do the tests still pass?
  • Is the code formatted properly?

Please describe additional details for testing this change

  1. Run npm run test:unit locally
  2. Trigger a login error, profile page error, or game list error and confirm errors still show in the UI
  3. Warnings now appear in console at warn level instead of log/error

@seriouslysean seriouslysean added dev experience Improvements to the code base that make it easier/better/more enjoyable to contribute to Cuttle version-patch An update that warrants a bumping the project's patch version (e.g. 4.0.0 => 4.0.1) labels Feb 8, 2026
Copilot AI review requested due to automatic review settings February 8, 2026 01:30
@seriouslysean seriouslysean self-assigned this Feb 8, 2026
@seriouslysean seriouslysean force-pushed the chore/replace-console-logging branch from 73ac757 to 16d005b Compare February 8, 2026 01:32

This comment was marked as outdated.

Rollbar is currently disabled (#1129), so the comments claiming
errors are "also handled by Rollbar's global handler" are misleading.
@Haviles04
Copy link
Contributor

LGTM

Copy link
Contributor

@itsalaidbacklife itsalaidbacklife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense; let's make the profile page error a user facing alert

Copilot AI review requested due to automatic review settings February 16, 2026 18:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…atch blocks

Address PR review feedback to surface user-facing errors on the profile
and home pages when game data fails to load, rather than silently
swallowing exceptions.
@itsalaidbacklife itsalaidbacklife merged commit efddeed into main Feb 18, 2026
9 checks passed
@itsalaidbacklife itsalaidbacklife deleted the chore/replace-console-logging branch February 18, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev experience Improvements to the code base that make it easier/better/more enjoyable to contribute to Cuttle version-patch An update that warrants a bumping the project's patch version (e.g. 4.0.0 => 4.0.1)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants