Record PIDs and refs in log traces #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we were dropping log entries with PIDs and refs,
which led to missing critical information for certain programs:
- when a process would send a message like {self(), 42}
- when a process would consume a message from the mailbox
The solver does not need to reason about these type, but just
"tolerate" them. We do not expect that they will be passed as
arguments to the unit under test, but they are being generated
as values during the execution of the program.
Fix spacing and wording of a comment.
kostis
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we were dropping log entries with PIDs and refs, which led to missing critical information for certain programs:
{self(), 42}The solver does not need to reason about these types, but just "tolerate" them. We do not expect that they will be passed as arguments to the unit under test, but they are being generated as values during the execution of the program.