-
-
Notifications
You must be signed in to change notification settings - Fork 275
Add Sonoff S-MATE and R5 switches #1497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi, @Ernst79. Could you please take a look? I tried my best to provide a complete PR with tests and documentation, ready to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM. However, two tests seem to fail. Not sure if Altbeacon is using the same UUID?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Altbeacon test now fail. We need to check why. They also use 0xFFFF as identifier
|
@Ernst79, should be fixed now. Can you re-ran the tests? |
Ernst79
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, thx. They now pass the test
Fixes #1456
Key notes:
References:
Screenshot: