feat : Context menu options in system diagram #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results77 tests 77 ✅ 15s ⏱️ Results for commit 64e2c61. ♻️ This comment has been updated with latest results. |
harmen-xb
reviewed
Dec 23, 2025
Contributor
harmen-xb
left a comment
harmen-xb
left a comment
There was a problem hiding this comment.
@remonaadite009 I added some questions on the code to understand some changes.
.../glsp-client/src/browser/system-diagram/context-menu/system-diagram-context-menu-provider.ts
Outdated
Show resolved
Hide resolved
remonaadite009
force-pushed
the
feature/diagram-context-menu
branch
from
13e8d82 to
23a9cf4
Compare
Contributor
|
@remonaadite009 I just tested the new implementation, and it seems to work. There are two things which should change still:
I think deactivating after single use is fine for context menu. |
remonaadite009
force-pushed
the
feature/diagram-context-menu
branch
from
ca53b8a to
3355c52
Compare
remonaadite009
force-pushed
the
feature/diagram-context-menu
branch
from
f8d5d09 to
64e2c61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.