fix: build error of README.md path#1368
Open
Mr-Sunglasses wants to merge 2 commits intocrate-ci:masterfrom
Open
fix: build error of README.md path#1368Mr-Sunglasses wants to merge 2 commits intocrate-ci:masterfrom
Mr-Sunglasses wants to merge 2 commits intocrate-ci:masterfrom
Conversation
Mr-Sunglasses
force-pushed
the
fix/build
branch
from
de78ed4 to
c494f15
Compare
Pull Request Test Coverage Report for Build 17329072823Details
💛 - Coveralls |
epage
reviewed
Aug 29, 2025
Collaborator
There was a problem hiding this comment.
iirc having this in that directory was to work around a different maturin issue.
Does symlinking the README work?
Contributor
Author
There was a problem hiding this comment.
Nope symlinking the README is now working.
❯ maturin sdist --manifest-path crates/typos-cli/Cargo.toml --out dist | xclip -sel clip
⚠️ Warning: `project.version` field is required in pyproject.toml unless it is present in the `project.dynamic` list
💥 maturin failed
Caused by: Failed to read readme specified in pyproject.toml, which should be at /home/kanishk/Projects/OSS/typos/crates/typos-cli/README.md
Caused by: failed to open file `/home/kanishk/Projects/OSS/typos/crates/typos-cli/README.md`: Symbolic link loop (os error 40)
Collaborator
|
FYI I did a super quick fix of removing the readme |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I see the there are build errors on the latest release to pypi in maturin action, the main cause of it is that it can't able to detect the
README.md, there are two possible solutionsREADME.mdtotypos-clidirectorypyproject.tomlin the rootI choose the second approach.