Bugfix/inline editing and conditions #18291
Merged
+20
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using inline editing (on the element index page), fields that were set to be not visible or editable still appeared as editable. If you made any changes to them via the inline editing mechanism, they were not saved.
Steps to reproduce:
With this PR in steps 6 and 7, you’ll see the field’s value, not the input, which should make it clear that they’re not editable this way.
Related issues
from a chat with @olivierbon