only show copy all action menu item if the field is part of an element #17416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make sure we're doing it for the inline-editable blocks view mode
brandonkelly
deleted the
bugfix/17404-matrix-field-copy-all-action-menu-item-part1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevents the “Copy all {type}” action menu item from showing for the Matrix field outside an element context.
I also opened a second PR for this issue, which prevents the item from being added altogether, instead of only hiding it when the disclosure menu is opened; however, it contains a potentially breaking change, so it’s targeting 5.8 for now.
Note: In 5.8, there are additional Expand and Collapse action menu items, which are already hidden when the disclosure menu is opened.
Related issues
#17404