-
-
Notifications
You must be signed in to change notification settings - Fork 186
Update Dependencies.cmake #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update compiler and OS versions
Update clang-format version
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
==========================================
+ Coverage 20.76% 20.85% +0.09%
==========================================
Files 5 5
Lines 236 211 -25
Branches 131 0 -131
==========================================
- Hits 49 44 -5
+ Misses 180 167 -13
+ Partials 7 0 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates dependency versions and toolchain configurations across the codebase. Key changes include:
- Updates to header includes and minor arithmetic expression clarifications in src/ftxui_sample/main.cpp.
- Replacement of "developer_mode" with "packaging_maintainer_mode" and upgrades of compiler and tool versions in CI and workflow files.
- Updates to clang-format, clang-tidy, and CodeQL configurations to align with the new dependency versions.
Reviewed Changes
Copilot reviewed 7 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/ftxui_sample/main.cpp | Added multiple headers, adjusted arithmetic expression parentheses for clarity, and scoped functions in anonymous namespaces. |
| fuzz_test/fuzz_tester.cpp | Updated include order and added new headers for consistency. |
| .github/workflows/template-janitor.yml | Changed compiler version and variable names to reflect updated modes. |
| .github/workflows/codeql-analysis.yml | Upgraded the compiler version used in CodeQL analysis. |
| .github/workflows/ci.yml | Updated OS and compiler matrix along with gcov executable naming to support new toolchain versions. |
| .github/workflows/auto-clang-format.yml | Upgraded the clang-format version for formatting checks. |
| .clang-tidy | Modified check configurations to disable/enable specific rules. |
Files not reviewed (6)
- CMakeLists.txt: Language not supported
- Dependencies.cmake: Language not supported
- ProjectOptions.cmake: Language not supported
- cmake/CPM.cmake: Language not supported
- cmake/StaticAnalyzers.cmake: Language not supported
- gcovr.cfg: Language not supported
No description provided.