Skip to content

Conversation

@lefticus
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 20.85%. Comparing base (8882ce9) to head (1cb3728).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/ftxui_sample/main.cpp 0.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   20.76%   20.85%   +0.09%     
==========================================
  Files           5        5              
  Lines         236      211      -25     
  Branches      131        0     -131     
==========================================
- Hits           49       44       -5     
+ Misses        180      167      -13     
+ Partials        7        0       -7     
Flag Coverage Δ
Linux ?
Windows 20.85% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@lefticus lefticus requested a review from Copilot April 23, 2025 16:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates dependency versions and toolchain configurations across the codebase. Key changes include:

  • Updates to header includes and minor arithmetic expression clarifications in src/ftxui_sample/main.cpp.
  • Replacement of "developer_mode" with "packaging_maintainer_mode" and upgrades of compiler and tool versions in CI and workflow files.
  • Updates to clang-format, clang-tidy, and CodeQL configurations to align with the new dependency versions.

Reviewed Changes

Copilot reviewed 7 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/ftxui_sample/main.cpp Added multiple headers, adjusted arithmetic expression parentheses for clarity, and scoped functions in anonymous namespaces.
fuzz_test/fuzz_tester.cpp Updated include order and added new headers for consistency.
.github/workflows/template-janitor.yml Changed compiler version and variable names to reflect updated modes.
.github/workflows/codeql-analysis.yml Upgraded the compiler version used in CodeQL analysis.
.github/workflows/ci.yml Updated OS and compiler matrix along with gcov executable naming to support new toolchain versions.
.github/workflows/auto-clang-format.yml Upgraded the clang-format version for formatting checks.
.clang-tidy Modified check configurations to disable/enable specific rules.
Files not reviewed (6)
  • CMakeLists.txt: Language not supported
  • Dependencies.cmake: Language not supported
  • ProjectOptions.cmake: Language not supported
  • cmake/CPM.cmake: Language not supported
  • cmake/StaticAnalyzers.cmake: Language not supported
  • gcovr.cfg: Language not supported

@lefticus lefticus merged commit bf180f6 into main Apr 23, 2025
31 checks passed
@lefticus lefticus deleted the update-dependencies-1 branch April 23, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants