feat: Allow creating instances with org domain #4636
Merged
+59
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Are you just storing metadata for now? No lookup function? |
shepilov
approved these changes
Jan 12, 2026
Member
Author
|
Yes, just storing. I was gonna add the lookup functions when actually using them. |
We want to store the custom domain of the parent organization of instances when it exists. This will allow us to query instances part of a given organization based on this custom domain.
taratatach
force-pushed
the
feat/add-org-domain-to-instances
branch
from
3ab8177 to
04d9b3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to store the custom domain of the parent organization of
instances when it exists.
This will allow us to query instances part of a given organization
based on this custom domain.