Add v1/orders POST endpoint to get orders in batches #4048
+188
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds POST handler for `v1/orders` endpoint that requires a list of order uids and responds with a vector of their data. Has a hardcoded limit of 5000 orders per request.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new endpoint v1/get_orders to retrieve orders in batches using a POST request with a limit of 5000 orders per request. The code adds a new module get_orders_by_uid.rs, modifies api.rs to include the new route, and updates database/orders.rs and orderbook.rs to support fetching multiple orders. I found a missing test case for the MAX_ORDERS_LIMIT validation.
Contributor
Author
|
Tested on sepolia staging: (queries twice for the same order) response |
Contributor
Author
|
By the way, we can have a discussion on what the endpoint itself should be. I got a couple suggestions from Claude
based on the above suggestions I have opted for a custom not-order-id-like name |
squadgazzz
requested changes
Jan 26, 2026
| async move { | ||
| Result::<_, Infallible>::Ok(match request_result { | ||
| Ok(uids) => { | ||
| let result = orderbook.get_orders(&uids).await; |
Contributor
There was a problem hiding this comment.
This will accumulate all the orders in memory, which is probably not a good idea. Can we instead return a stream of data directly from the DB?
Comment on lines
325
to
344
| for uid in uids { | ||
| results.push( | ||
| match orders::single_full_order_with_quote(&mut ex, &ByteArray(uid.0)).await? { | ||
| Some(order_with_quote) => { | ||
| let (order, quote) = order_with_quote.into_order_and_quote(); | ||
| Some(full_order_with_quote_into_model_order( | ||
| order, | ||
| quote.as_ref(), | ||
| )) | ||
| } | ||
| None => { | ||
| // try to find the order in the JIT orders table | ||
| database::jit_orders::get_by_id(&mut ex, &ByteArray(uid.0)) | ||
| .await? | ||
| .map(full_order_into_model_order) | ||
| } | ||
| } | ||
| .transpose(), | ||
| ); | ||
| } |
Contributor
There was a problem hiding this comment.
Sequential fetching of 5k orders will result in a nightmare performance.
Contributor
There was a problem hiding this comment.
The best option is to introduce a query to fetch everything at once using the QueryBuilder. There are many examples in the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Aave wants to track specific orders in bulk, knowing their ids.
Changes
Adds POST handler for
v1/orders/lookupendpoint that requires a list of order uids and responds with a vector of their data. Has a hardcoded limit of 5000 orders per request.How to test
Test on staging, query multiple orders using this API.