[4.0.3 backport] CBG-5079: Avoid logging at debug in pruning of cache #7985
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR backports performance improvements related to cache pruning logging. The changes reduce logging overhead by moving debug-level pruning messages to trace level with conditional checks.
Changes:
- Reduced vBucket creation delay from 500ms to 100ms in the cache performance tool
- Changed pruning log messages from debug to trace level with conditional evaluation guards
- Updated loop syntax to use range expression
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/cache_perf_tool/dcpDataGeneration.go | Updated vBucket creation loop syntax and reduced sleep delay for faster iteration |
| db/channel_cache_single.go | Changed cache pruning log messages from debug to trace level with conditional guards to avoid unnecessary UD() calls |
bbrks
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[4.0.3 backport] CBG-5079: Avoid logging at debug in pruning of cache
cherry-pick of 7691406