[4.0.3 backport] CBG-5073: Deduplicate channel set outside processEntry #7983
+72
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR backports changes that refactor channel set handling in the change cache implementation to use slices instead of maps, with deduplication occurring after entry processing rather than during it.
Changes:
- Refactored
AddToCacheto return[]channels.IDinstead ofchannels.Set - Updated all callers to convert channel slices to sets after processing
- Added dedicated
notifyChangehelper function for consistent channel notification handling
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| db/channel_cache.go | Changed AddToCache return type from channels.Set to []channels.ID, using slice append instead of set operations |
| db/change_cache_test.go | Updated test comments from notifyChange to notifyChangeFunc to match renamed field |
| db/change_cache.go | Refactored channel tracking to use slices during processing, added notifyChange helper, converted slices to sets before notification |
| // push unused range to either pending or skipped lists based on current state of the change cache | ||
| allChangedChannels = c.processUnusedRange(ctx, fromSequence, toSequence, allChangedChannels, timeReceived) | ||
| changedChannels := c.processUnusedRange(ctx, fromSequence, toSequence, timeReceived) | ||
| allChangedChannels.Update(channels.SetFromArrayNoValidate(changedChannels)) |
There was a problem hiding this comment.
The return value of Update is not being captured. Since the method likely returns the updated set rather than modifying in place, this line should be allChangedChannels = allChangedChannels.Update(...) to preserve the changes.
Suggested change
| allChangedChannels.Update(channels.SetFromArrayNoValidate(changedChannels)) | |
| allChangedChannels = allChangedChannels.Update(channels.SetFromArrayNoValidate(changedChannels)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[4.0.3 backport] CBG-5073: Deduplicate channel set outside processEntry
cherry-pick of d469545