Optimize StatusCode Line Matching for ASCII #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
String.matches(String regex) results in a re-compilation of the regex every single invocation. Instead of using an underlying inefficient Pattern/Matcher, instead use String.startsWith(String prefix). This optimization matters for high throughput usecases when an endpoint goes down and the number of SERVER_ERROR spikes dramatically.
Author
|
Hey @ingenthr , any chance you could take a look at this and my other pull requests in the near future? Thanks! |
|
Yep, had a look y'day, and planning to do a bit more today. I'm working at getting them in and another update. |
Author
|
@ingenthr re-bumping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String.matches(String regex) results in a re-compilation of the regex
every single invocation. Instead of using an underlying inefficient
Pattern/Matcher, instead use String.startsWith(String prefix). This
optimization matters for high throughput usecases when an endpoint
goes down and the number of SERVER_ERROR spikes dramatically.