Fix exceptions usage #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...because they do not have stack trace I saw that it was intentionally done in 2014 for improving performance. But I think that this intention was wrong. This exception is thrown very rarely. In normal circumstances, people never use invalid key. If they make an error in their code, they will find it immediately in development phase and fix. They will almost never get this exception in production. It will not affect performance. Think wider: if application cache doesn't work because of invalid key, you will have much more serious performance problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...because they do not have stack trace
I saw that it was intentionally done in 2014 for improving performance. But I think that this intention was wrong. This exception is thrown very rarely.
In normal circumstances, people never use invalid key. If they make an error in their code, they will find it immediately in development phase and fix. They will almost never get this exception in production. It will not affect performance.
Think wider: if application cache doesn't work because of invalid key, you will have much more serious performance problem.