-
-
Notifications
You must be signed in to change notification settings - Fork 35
ci: don't run ignored doctests in coverage tests #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR modifies the code coverage workflow to separate the generation of coverage for regular tests and doctests. Previously, the --doctests flag was combined with --include-ignored, which would run ignored doctests during coverage collection. The change splits this into two separate coverage runs: one for regular tests (including ignored tests), and one specifically for doctests (without the --include-ignored flag).
Changes:
- Split code coverage generation into two separate commands: one for regular tests with
--include-ignored, and one for doctests without it - Updated the codecov upload to include both coverage files
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/rust.yml
Outdated
| - uses: codecov/codecov-action@v5 | ||
| with: | ||
| files: coverage.json | ||
| files: coverage.json codecov-doctests.json |
Copilot
AI
Jan 16, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first filename should be codecov.json (not coverage.json) to match the output file from line 227.
| files: coverage.json codecov-doctests.json | |
| files: codecov.json codecov-doctests.json |
7212ab8 to
cb1801d
Compare
|
| Branch | fix-doctest-coverage |
| Testbed | github-ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (µs) (Result Δ%) | Upper Boundary microseconds (µs) (Limit %) |
|---|---|---|---|
| empty_router/empty_router | 📈 view plot 🚷 view threshold | 5,119.10 µs(-14.92%)Baseline: 6,017.02 µs | 6,927.90 µs (73.89%) |
| json_api/json_api | 📈 view plot 🚷 view threshold | 877.93 µs(-13.71%)Baseline: 1,017.46 µs | 1,152.11 µs (76.20%) |
| nested_routers/nested_routers | 📈 view plot 🚷 view threshold | 815.90 µs(-13.25%)Baseline: 940.56 µs | 1,060.00 µs (76.97%) |
| single_root_route/single_root_route | 📈 view plot 🚷 view threshold | 788.51 µs(-12.46%)Baseline: 900.72 µs | 1,013.07 µs (77.83%) |
| single_root_route_burst/single_root_route_burst | 📈 view plot 🚷 view threshold | 17,843.00 µs(+1.28%)Baseline: 17,617.44 µs | 20,919.27 µs (85.29%) |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
5f18d05 to
0413414
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
See #446 for more context.