Draft
Conversation
friedrichg
force-pushed
the
upgrade-go
branch
from
c8bd669 to
26fd3e9
Compare
Signed-off-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com>
Signed-off-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com>
Signed-off-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com>
Signed-off-by: Friedrich Gonzalez <1517449+friedrichg@users.noreply.github.com>
friedrichg
force-pushed
the
upgrade-go
branch
from
3d119c7 to
03cb3f2
Compare
friedrichg
commented
Sep 8, 2025
| @@ -1,35 +0,0 @@ | |||
| package exec | |||
Member
Author
There was a problem hiding this comment.
cortexproject/cortex doesn't use this
|
|
||
| // Add a blank line between cmd description and list of options | ||
| if fs.FlagCount() > 0 { | ||
| fmt.Fprintln(writer, "") |
Member
Author
There was a problem hiding this comment.
This part appears to be part of the older docker project. I bet there is an updated version somewhere. Not fixing the bugs in this PR
| @@ -1,33 +0,0 @@ | |||
| package network | |||
Member
Author
There was a problem hiding this comment.
cortexproject/cortex doesn't use this
| @@ -1,24 +0,0 @@ | |||
| package test | |||
Member
Author
There was a problem hiding this comment.
cortexproject/cortex doesn't use this
| if err != nil { | ||
| return nil, err | ||
| } | ||
| defer fh.Close() |
Member
Author
There was a problem hiding this comment.
fs/fs.go:34:16: Error return value of `fh.Close` is not checked (errcheck)
defer fh.Close()
But cortexproject/cortex doesn't use this, so let's remove it
| } | ||
|
|
||
| func (c *realCmd) SetEnv(env []string) { | ||
| c.Cmd.Env = env |
Member
Author
There was a problem hiding this comment.
exec/exec.go:34:4: QF1008: could remove embedded field "Cmd" from selector (staticcheck)
c.Cmd.Env = env
| head, tail := split(path) | ||
| fs, ok := p.entries[head] | ||
| if !ok { | ||
| return nil, fmt.Errorf("Not found: %s", path) |
Member
Author
There was a problem hiding this comment.
test/fs/fs.go:89:15: ST1005: error strings should not be capitalized (staticcheck)
return nil, fmt.Errorf("Not found: %s", path)
| head, tail := split(path) | ||
| fs, ok := p.entries[head] | ||
| if !ok { | ||
| return nil, fmt.Errorf("Not found: %s", path) |
Member
Author
There was a problem hiding this comment.
test/fs/fs.go:117:15: ST1005: error strings should not be capitalized (staticcheck)
return nil, fmt.Errorf("Not found: %s", path)
|
|
||
| func (p dir) ReadFile(path string) ([]byte, error) { | ||
| if path == "/" { | ||
| return nil, fmt.Errorf("I'm a directory") |
Member
Author
There was a problem hiding this comment.
test/fs/fs.go:130:15: ST1005: error strings should not be capitalized (staticcheck)
return nil, fmt.Errorf("I'm a directory")
| fmt.Printf("Error updating scheduler: %v\n", err) | ||
| } else { | ||
| resp.Body.Close() | ||
| resp.Body.Close() //nolint:errcheck |
Member
Author
There was a problem hiding this comment.
no idea if changing this means anything
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.