Adding support for load_state_dict with assign=True for priors of Transformed distributions #2691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
Author
Balandat
reviewed
Dec 19, 2025
hvarfner
force-pushed
the
state_dict_assign
branch
from
6ce060b to
5c174a1
Compare
Balandat
reviewed
Jan 20, 2026
Balandat
approved these changes
Feb 10, 2026
| # Prefix for buffered attributes in TransformedDistributions. | ||
| # These are copies of the base distribution attributes, enabling state_dict | ||
| # save/load since the original attributes are properties and cannot be bufferized. | ||
| BUFFERED_PREFIX = "_buffered_" |
Collaborator
There was a problem hiding this comment.
would changing this from _transformed_ to __buffered__ cause issues with backward compatibility of loading a state dict?
Collaborator
There was a problem hiding this comment.
Not sure if this would be a big deal, it's probably not super widely used so I think we could merge this even if this breaks BC.
Contributor
Author
There was a problem hiding this comment.
Yes, it would unfortunately.
hvarfner
force-pushed
the
state_dict_assign
branch
from
dfa1d23 to
1b777f8
Compare
hvarfner
force-pushed
the
state_dict_assign
branch
from
2ff825a to
e35b828
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required changes in GPytorch to unblock meta-pytorch/botorch#3080. When
load_state_dictis called withassign=True,setattris called on_transformedattributes of the prior at the pytorch level.This was not the intended use of the
_transformedattribute, but it seems like we have to enable its modification directly.