Skip to content

Conversation

@itemkelvin
Copy link
Collaborator

All ops in file NeuraOps.dt have been implemented, and test cases have been saved in path ./test/neura/interpreter/ .

@tancheng
Copy link
Contributor

tancheng commented Jul 9, 2025

Thanks for the update @itemkelvin, it seems we need to fix the Github Action by revising the CHECK inside the .mlir (as the dump is removed?). Maybe we can just CHECK the final output?

Thanks!

@itemkelvin
Copy link
Collaborator Author

Thanks for the update @itemkelvin, it seems we need to fix the Github Action by revising the CHECK inside the .mlir (as the dump is removed?). Maybe we can just CHECK the final output?

Thanks!

Correct CHECKs have been added to the test cases, and the workflow in Git Action has run successfully.

Copy link
Contributor

@tancheng tancheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job. I just have a concern about the dump's condition. I believe deepseek/gpt can help you set up the flag for interpreter to enable the conditional dump. Plz try, thanks @itemkelvin~!

@tancheng
Copy link
Contributor

Hi @itemkelvin, any blockers to resolve the comments? We can discuss alternatives if they are hard to fix?

@itemkelvin
Copy link
Collaborator Author

itemkelvin commented Jul 20, 2025

Hi @itemkelvin, any blockers to resolve the comments? We can discuss alternatives if they are hard to fix?

I sincerely apologize for the delay in code development. I've been swamped with other tasks these days, which has affected my progress. Rest assured, I'll prioritize this project and catch up as soon as possible. Now I've completed all the code modifications, and all op execution logs support verbose mode. In addition, I've adjusted the logging format to make it easier to monitor the execution status as follows.
QQ截图20250720183110

@tancheng
Copy link
Contributor

Hi @itemkelvin, any blockers to resolve the comments? We can discuss alternatives if they are hard to fix?

I sincerely apologize for the delay in code development. I've been swamped with other tasks these days, which has affected my progress. Rest assured, I'll prioritize this project and catch up as soon as possible. Now I've completed all the code modifications, and all op execution logs support verbose mode. In addition, I've adjusted the logging format to make it easier to monitor the execution status as follows. QQ截图20250720183110

Thanks @itemkelvin~! Great work~!

I just left a few more comments, which can be easily fixed by you.

The next step could be interpreter for dataflow execution #42, plz let @ShangkunLi know if you have any questions when you enable/implement it for https://github.com/coredac/dataflow/blob/main/test/neura/ctrl/branch_for.mlir. And feel free to schedule 1:1 with me if needed :-)

@tancheng tancheng added the new feature New feature or request label Jul 21, 2025
Copy link
Contributor

@tancheng tancheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~! Let's see whether the test passes in Github Action so then we can merge this PR :-)

@itemkelvin itemkelvin merged commit 493f4cb into main Jul 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants