-
Notifications
You must be signed in to change notification settings - Fork 15
Interpreter v1.0.0 #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the update @itemkelvin, it seems we need to fix the Github Action by revising the Thanks! |
Correct CHECKs have been added to the test cases, and the workflow in Git Action has run successfully. |
tancheng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent job. I just have a concern about the dump's condition. I believe deepseek/gpt can help you set up the flag for interpreter to enable the conditional dump. Plz try, thanks @itemkelvin~!
|
Hi @itemkelvin, any blockers to resolve the comments? We can discuss alternatives if they are hard to fix? |
I sincerely apologize for the delay in code development. I've been swamped with other tasks these days, which has affected my progress. Rest assured, I'll prioritize this project and catch up as soon as possible. Now I've completed all the code modifications, and all op execution logs support verbose mode. In addition, I've adjusted the logging format to make it easier to monitor the execution status as follows. |
Thanks @itemkelvin~! Great work~! I just left a few more comments, which can be easily fixed by you. The next step could be |
tancheng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~! Let's see whether the test passes in Github Action so then we can merge this PR :-)


All ops in file NeuraOps.dt have been implemented, and test cases have been saved in path ./test/neura/interpreter/ .