Skip to content

Introduce grant_always operation #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tancheng merged 2 commits into from
Jun 19, 2025
Merged

Introduce grant_always operation #49

tancheng merged 2 commits into from
Jun 19, 2025

Conversation

@tancheng
Copy link
Contributor

@tancheng tancheng commented Jun 18, 2025

Introduce grant_always operation.

  • The grant_always is different from grant_once, but both are within entry block.
  • New test is added.
    • Create a case that a variable (in entry block) is used by both branch's argument and non-arg style that is directly consumed by successor blocks.

@tancheng tancheng self-assigned this Jun 18, 2025
@tancheng tancheng added bug Something isn't working new feature New feature or request labels Jun 18, 2025
@tancheng tancheng linked an issue Jun 18, 2025 that may be closed by this pull request
[P1] grant_always might be needed #45
Closed
ShangkunLi
ShangkunLi reviewed Jun 19, 2025
View reviewed changes
@tancheng tancheng merged commit cf5983b into main Jun 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShangkunLi ShangkunLi ShangkunLi approved these changes

@yuqisun yuqisun Awaiting requested review from yuqisun

@Yfeng-44 Yfeng-44 Awaiting requested review from Yfeng-44

@YanzhouTang YanzhouTang Awaiting requested review from YanzhouTang

Assignees

@tancheng tancheng

Labels

bug Something isn't working new feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[P1] grant_always might be needed

3 participants

@tancheng @ShangkunLi