Analysis of compiled_ii changes in spatial-temporal mapping optimization #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
compare the commited test files and main to compare the changes in |
Copilot
AI
changed the title
[WIP] Optimize spatial-temporal heuristic and reduce II for multiple kernels
Analysis of compiled_ii changes in spatial-temporal mapping optimization
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a comprehensive analysis of the
compiled_ii(Initiation Interval) changes resulting from the spatial-temporal mapping heuristic optimizations, comparing the current implementation against the main branch baseline.Analysis Results
Examined all 16 test files containing
compiled_iivalues:Improvements (3 test cases):
bicg_kernel.mlir: 13 → 1 (-12)perfect_nested.mlir: 10 → 8 (-2)simple_loop_reduction.mlir: 4 → 3 (-1)Regressions (1 test case):
tiny_loop.mlir: 4 → 6 (+2)Unchanged (12 test cases): Includes
test_code_generate.mlir,nested_loop/test.mlir, andfusion/test.mlirwhich remain at their main branch values (5, 13, and 13 respectively).Discrepancy with Original Claims
The PR description claimed 5 improvements, but only 2 are realized in the current code:
simple_loop_reduction.mlirandperfect_nested.mlirachieve claimed reductionstest_code_generate.mlir,nested_loop/test.mlir, andfusion/test.mlirshow no improvementNet impact: -13 total compiled_ii reduction across changed tests.
This analysis addresses the stability concerns raised in comments about non-deterministic mapping results and clarifies the actual performance characteristics of the current implementation.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.