update dask vine executor to new dask graphs#4015
Merged
btovar merged 12 commits intocooperative-computing-lab:masterfrom Jan 17, 2025
Merged
update dask vine executor to new dask graphs#4015btovar merged 12 commits intocooperative-computing-lab:masterfrom
btovar merged 12 commits intocooperative-computing-lab:masterfrom
Conversation
Member
Author
|
Figuring out an error with coffea's CI. |
Member
Author
|
Ok, it seems to be working. |
Member
|
I am going to try with the new one. |
dthain
reviewed
Jan 14, 2025
Member
dthain
left a comment
dthain
left a comment
There was a problem hiding this comment.
The overall approach makes sense to me.
I am concerned about how we deal with backwards/forwards compatibility, esp for physics applications which have not necessarily been ported to the new version of Dask.
Do you have any ideas how to support this migration? We don't need to keep compatibility forever, but we also can't expect our key users to all change at the same time.
At the very least, we need to be very explicit in the manual about the supported version, and also note that in our Conda environments.
dthain
reviewed
Jan 14, 2025
btovar
added a commit
that referenced
this pull request
Jan 17, 2025
* DaskVine to new graph representation * update simple graph example * fix bug with depth * always convert from legacy representation, for now * check for dask in test * do not import DaskVineDag if dask not available * update function calls * lint * handle generic container graph nodes * add warning about dask version * example_to_revert * remove print statement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make testRun local tests prior to pushing.make formatFormat source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)make lintRun lint on source code prior to pushing.