-
Notifications
You must be signed in to change notification settings - Fork 124
vine: properly replicate temp files #4004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
btovar
merged 10 commits into
cooperative-computing-lab:master
from
JinZhou5042:temp_replica_count
Dec 10, 2024
Merged
vine: properly replicate temp files #4004
btovar
merged 10 commits into
cooperative-computing-lab:master
from
JinZhou5042:temp_replica_count
Dec 10, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthain
reviewed
Dec 10, 2024
Member
Author
dthain
approved these changes
Dec 10, 2024
Member
dthain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Member
Author
|
RTM |
btovar
approved these changes
Dec 10, 2024
btovar
pushed a commit
that referenced
this pull request
Dec 14, 2024
* print rep count * init * update * up * up * up * lint * up * limit the max number of rep attempts * update
dthain
pushed a commit
to dthain/cctools
that referenced
this pull request
Jan 10, 2025
* print rep count * init * update * up * up * up * lint * up * limit the max number of rep attempts * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Proposed Changes
Fix #3996
Update the default values for a set of arguments regarding temp file replication:
q->worker_source_max_transfersfrom 3 to 10max_transfer_procsfrom 5 to 10q->transfer_replica_per_cycleas is (which is 10), as it limits the number of replications to request per temp file per iteration, and we are not likely to replicate each temp file more than 10 times.Improve the logic in the replication process, which helps the manager replicate more efficiently, add more comments
Provide an API for Python to query the replica count for a file
Merge Checklist
The following items must be completed before PRs can be merged.
Check these off to verify you have completed all steps.
make testRun local tests prior to pushing.make formatFormat source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)make lintRun lint on source code prior to pushing.