vine factory:always use manager.name as fallback when no host:port is available

[btovar]

Fix #3999

Proposed Changes

Give an overall description of the changes, along with the context and motivation.
Mention relevant issues and pull requests as needed.

Merge Checklist

The following items must be completed before PRs can be merged.
Check these off to verify you have completed all steps.

• make test Run local tests prior to pushing.
• make format Format source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)
• make lint Run lint on source code prior to pushing.
• Manual Update: Update the manual to reflect user-visible changes.
• Type Labels: Select a github label for the type: bugfix, enhancement, etc.
• Product Labels: Select a github label for the product: TaskVine, Makeflow, etc.
• PR RTM: Mark your PR as ready to merge.

[colinthomas-z80]

Make sure this works even when both manager name and object are specified. like:

Factory(manager=m, manager_name="xyz")

Where it "working" means that Factory(manager=m, manager_name="xyz", batch_type="condor") will produce workers that point to your hostname:port rather than localhost:port

[btovar]

localhost:port should only be set when using batch_type local. Is this not the case?

[colinthomas-z80]

Yeah the problem I brought up in the issue was that when the manager object is passed to the factory it always invokes the worker with localhost:port regardless of batch type or other kwargs. So condor workers would not connect

[btovar]

So this pr does not solve it? In the examples you posted in the issue the batch type is not being set, so it defaults to "local", and that's why the localhost:port is used. This pr is trying to make it so that you only get localhost:port if you specified a manager and the batch_type is local.

[colinthomas-z80]

It might be that I was creating the factory giving only the manager object as an argument, then modifying the factory object afterwards like f.batch_type = "condor". So the batch type gets changed but it does not modify the manager_hostport

[colinthomas-z80]

Could we stop using localhost and always use a proper hostname so that local and remote workers can resolve if batch_type gets changed on the fly?

[btovar]

I'm more inclined to forbid changing the batch type and manager host port after init. This would reflect what the vine_factory command line does. We should only update parameters that correspond to fields in the config file once the factory is created. The localhost:port default is meant to be user friendly for the introductory examples.

[colinthomas-z80]

Sounds good to me.

[btovar]

does this one work for you?

[colinthomas-z80]

yes!