Skip to content

Conversation

@hiteshshetty-dev
Copy link
Contributor

Title

Add support for Variant highlights

Description

We have introduced new class for outline and migrated outline style from generic class for better readability and have those class have single responsibitiy.
We have introduce global state for highlightVariant & variantOrder to remove dependency as props for few utils function.
Whenever variant changes or DOM has any changes we recalculate variant classname.

Screen.Recording.2025-12-05.at.10.06.59.AM.mov

@hiteshshetty-dev hiteshshetty-dev requested a review from a team as a code owner December 5, 2025 04:37
@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 71.63% 8019 / 11195
🔵 Statements 71.63% 8019 / 11195
🔵 Functions 74.7% 319 / 427
🔵 Branches 85.27% 1193 / 1399
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/visualBuilder/index.ts 60.94% 64.7% 42.85% 60.94% 102-109, 112-116, 119-131, 134-207, 213-248, 256-278, 329-332, 335-336, 389-395
src/visualBuilder/visualBuilder.style.ts 100% 100% 100% 100%
src/visualBuilder/eventManager/useRecalculateVariantDataCSLPValues.ts 9.27% 100% 50% 9.27% 22-26, 30-177
src/visualBuilder/eventManager/useVariantsPostMessageEvent.ts 98.71% 92.1% 100% 98.71% 50-51
Generated in workflow #729 for commit 298ad6a by the Vitest Coverage Report Action

Copy link
Contributor

@faraazb faraazb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment

@hiteshshetty-dev hiteshshetty-dev requested a review from a team as a code owner January 2, 2026 09:55
Copy link
Contributor

@faraazb faraazb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hiteshshetty-dev hiteshshetty-dev merged commit 28ea4b2 into develop_v4 Jan 2, 2026
10 checks passed
@hiteshshetty-dev hiteshshetty-dev deleted the VB-138+sync-dev branch January 2, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants