-
Notifications
You must be signed in to change notification settings - Fork 1
Add support for Variant highlights #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… add new utility tests
…perms' into VB-138+sync
…n useVariantsPostMessageEvent
…n editButtonAction tests
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
…calls and their counts
faraazb
requested changes
Jan 2, 2026
Contributor
faraazb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment
src/visualBuilder/eventManager/__test__/useVariantsPostMessageEvent.spec.ts
Outdated
Show resolved
Hide resolved
faraazb
approved these changes
Jan 2, 2026
Contributor
faraazb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Add support for Variant highlights
Description
We have introduced new class for outline and migrated outline style from generic class for better readability and have those class have single responsibitiy.
We have introduce global state for highlightVariant & variantOrder to remove dependency as props for few utils function.
Whenever variant changes or DOM has any changes we recalculate variant classname.
Screen.Recording.2025-12-05.at.10.06.59.AM.mov