Skip to content

Conversation

@elezar
Copy link
Contributor

@elezar elezar commented Feb 10, 2026

This PR is a response to https://github.com/containers/podman/pull/28008/changes#r2787912757

This changes how container.conf and host_device_list CDI devices
are handled. Instead of injecting these separately (requiring)
separate instatiations of a CDI cache, these are pre-processed to
extract the list of CDI device names. These CDI devices are then
added to the list of CDI devices names from explicit --device requests
and implicit requests from the --gpus flag.

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
    commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
    the sign-off email address. See CONTRIBUTING.md
    for more information.
  • Referenced issues using Fixes: #00000 in commit message (if applicable)
  • Tests have been added/updated (or no tests are needed)
  • Documentation has been updated (or no documentation changes are needed)
  • All commits pass make validatepr (format/lint checks)
  • Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

None

…ption

Signed-off-by: Shiv Tyagi <Shiv.Tyagi@amd.com>
@packit-as-a-service
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@elezar
Copy link
Contributor Author

elezar commented Feb 10, 2026

This still includes the commits from #28008. I will rebase and rework as soon as that's merged.

This changes how container.conf and host_device_list CDI devices
are handled. Instead of injecting these separately (requiring)
separate instatiations of a CDI cache, these are pre-processed to
extract the list of CDI device names. These CDI devices are then
added to the list of CDI devices names from explicit --device requests
and implicit requests from the --gpus flag.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar force-pushed the rework-devices-from-path branch from bc6e60c to dc09a0c Compare February 10, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants