Rewrite virtio-net IO to be more efficient #530
Draft
mtjhrc wants to merge 18 commits intocontainers:mainfrom
Draft
Rewrite virtio-net IO to be more efficient #530mtjhrc wants to merge 18 commits intocontainers:mainfrom
mtjhrc wants to merge 18 commits intocontainers:mainfrom
Conversation
mtjhrc
force-pushed
the
vectored-io-net
branch
2 times, most recently
from
5220656 to
db2af02
Compare
mtjhrc
force-pushed
the
vectored-io-net
branch
4 times, most recently
from
bccf5ac to
3e444c0
Compare
Signed-off-by: Matej Hrica <mhrica@redhat.com>
Use correct platform-specific library directory (lib vs lib64) and library path env variable (DYLD_LIBRARY_PATH vs LD_LIBRARY_PATH). Signed-off-by: Matej Hrica <mhrica@redhat.com>
Signed-off-by: Matej Hrica <mhrica@redhat.com>
Signed-off-by: Matej Hrica <mhrica@redhat.com>
Make TcpTester::run_server also leak the file descriptor for the stream socket. Closing the fd caused the tests to fail on macOS (they randomly worked on Linux I suppose). Signed-off-by: Matej Hrica <mhrica@redhat.com>
Explicitly specify a /tmp directory, this fixes an issue on macOS where the default tmp path that gets used could be very long, causing unix domain socket tests to fail due to path length. Signed-off-by: Matej Hrica <mhrica@redhat.com>
This flag should be used to indicate to libkrun that downstream network backend wants to receive and transmit the virtio-net header along with Ethernet frames. Network backends using this flag can then forward unmodified headers to another VM or build a sensible virtio_net_hdr (e.g. with GSO fields correctly set) such that receiving VM handles GSO'd frames properly. Signed-off-by: Albin Kerouanton <albin.kerouanton@docker.com>
Signed-off-by: Matej Hrica <mhrica@redhat.com>
Signed-off-by: Matej Hrica <mhrica@redhat.com>
Signed-off-by: Matej Hrica <mhrica@redhat.com>
Introduce TxQueueConsumer and RxQueueProducer utilities, which allow consuming virtio queues as a bunch of iovec vectors. Notably these utilities are different than the preexisiting descriptor_utilis. The Reader and Writer in descriptor utilis operate on the order of single descriptor chains and don't allow the multiple descriptor chains to be processed at once due to borrowing issues, wheras these the TxQueueConsumer/RxQueueProducer operate on the order of all descriptors of all descriptor chains at once allowing for batch processing of the whole queue at once. Signed-off-by: Matej Hrica <mhrica@redhat.com>
Rewrite the all of the backend (unixstream, unixgram, tap) in terms of the new RxQueueProducer/TxQueueConsumer abstractions. Signed-off-by: Matej Hrica <mhrica@redhat.com>
Signed-off-by: Matej Hrica <mhrica@redhat.com>
mtjhrc
force-pushed
the
vectored-io-net
branch
from
3e444c0 to
398016b
Compare
Restore accidentally deleted guest-agent crate. Signed-off-by: Matej Hrica <mhrica@redhat.com>
Signed-off-by: Matej Hrica <mhrica@redhat.com>
mtjhrc
force-pushed
the
vectored-io-net
branch
from
6e14f63 to
d09264b
Compare
Signed-off-by: Matej Hrica <mhrica@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
RxQueueProducer,TxQueueConsumer) in an efficient mannerTODO:
Adresses: #385, #405
supersedes: #493