Support running integration tests on macOS#524
Open
mtjhrc wants to merge 6 commits intocontainers:mainfrom
Open
Support running integration tests on macOS#524mtjhrc wants to merge 6 commits intocontainers:mainfrom
mtjhrc wants to merge 6 commits intocontainers:mainfrom
Conversation
mtjhrc
force-pushed
the
tests-macos-support
branch
6 times, most recently
from
3159e54 to
edf1b4d
Compare
mtjhrc
changed the title
mtjhrc
force-pushed
the
tests-macos-support
branch
6 times, most recently
from
3bafd76 to
abdaf7e
Compare
mtjhrc
requested review from
MatiasVara,
jakecorrenti,
slp and
tylerfanelli
as code owners
mtjhrc
force-pushed
the
tests-macos-support
branch
from
abdaf7e to
5808778
Compare
mtjhrc
force-pushed
the
tests-macos-support
branch
5 times, most recently
from
e0795f9 to
126ed51
Compare
Collaborator
Author
|
After the fixes to to the tests in this PR and #543 which fixes an issue in the implementation all tests now pass on macOS correctly. |
Signed-off-by: Matej Hrica <mhrica@redhat.com>
Use correct platform-specific library directory (lib vs lib64) and library path env variable (DYLD_LIBRARY_PATH vs LD_LIBRARY_PATH). Signed-off-by: Matej Hrica <mhrica@redhat.com>
Signed-off-by: Matej Hrica <mhrica@redhat.com>
Signed-off-by: Matej Hrica <mhrica@redhat.com>
Make TcpTester::run_server also leak the file descriptor for the stream socket. Closing the fd caused the tests to fail on macOS (they randomly worked on Linux I suppose). Signed-off-by: Matej Hrica <mhrica@redhat.com>
Explicitly specify a /tmp directory, this fixes an issue on macOS where the default tmp path that gets used could be very long, causing unix domain socket tests to fail due to path length. Signed-off-by: Matej Hrica <mhrica@redhat.com>
mtjhrc
force-pushed
the
tests-macos-support
branch
from
946e1e2 to
03d29c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes sure our
make testsimply just works on macOS.Note that this currently utilizes the same tests as linux which is the
libkrunfw/virtio-fsuse-case (not the commonly used EFI+disk variant on macOS), these test can hopefully be added later, still though this is quite useful for testing virtio devices.This also disables vsock and tsi/vsock tests since these currently fail on macOS (the TSI is understandable, but I'm not sure about the vsock failure) - we can investigate or declare this unsupported later.TODO:
Since we currently don't have a macOS CI that supports virtualization, these tests still have to be ran locally.