add MAC, IPv4, IPv6 addresses to nework inspect#4680
Open
coderbirju wants to merge 1 commit intocontainerd:mainfrom
Open
add MAC, IPv4, IPv6 addresses to nework inspect#4680coderbirju wants to merge 1 commit intocontainerd:mainfrom
coderbirju wants to merge 1 commit intocontainerd:mainfrom
Conversation
2385db1 to
eb356cf
Compare
haytok
reviewed
Jan 10, 2026
eb356cf to
365205b
Compare
Contributor
Author
|
Apologies for the late reply, you're right we can skip the assert statements as the field existence is already validated through struct unmarshaling. |
haytok
reviewed
Feb 1, 2026
365205b to
0756765
Compare
Contributor
Author
|
Failures seem to be unrelated to the changes |
Member
|
Thanks for fixes. I'll reply within this week 🙏 |
haytok
reviewed
Feb 21, 2026
0756765 to
e37c5bd
Compare
Signed-off-by: Arjun Raja Yogidas <arjunry@amazon.com>
e37c5bd to
6d2a7ad
Compare
Contributor
Author
|
CI Faliures can be attributed to #4782 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current network inspect respone provides only container names
This PR adds other fields in the EndpointResource Struct
Testing:
CIDR Notation:
Result
Multi-Network Container:
-hoge
-fuga