Skip to content

Adding Polyglotdb with dependencies conch_sounds and pyraat #18313

Closed
michaelhaaf wants to merge 10 commits intoconda-forge:mainfrom
michaelhaaf:polyglotdb
Closed

Adding Polyglotdb with dependencies conch_sounds and pyraat #18313
michaelhaaf wants to merge 10 commits intoconda-forge:mainfrom
michaelhaaf:polyglotdb

Conversation

@michaelhaaf
Copy link

@michaelhaaf michaelhaaf commented Mar 12, 2022

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/conch_sounds, recipes/polyglotdb, recipes/pyraat) and found some lint.

Here's what I've got...

For recipes/conch_sounds:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

For recipes/polyglotdb:

  • The summary item is expected in the about section.

@michaelhaaf michaelhaaf changed the title Polyglotdb Adding Polyglotdb with dependencies conch_sounds and pyraat Mar 12, 2022
@michaelhaaf michaelhaaf mentioned this pull request Mar 12, 2022
9 tasks
@mmcauliffe
Copy link
Contributor

I am willing to be listed as a maintainer, thanks!

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/conch_sounds, recipes/polyglotdb, recipes/pyraat) and found it was in an excellent condition.

@michaelhaaf
Copy link
Author

@conda-forge/staged-recipes recipe looks ready to go!

about:
home: https://github.com/mmcauliffe/Pyraat
summary: Interface for running Praat scripts through Python
license: MIT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream has two licenses. Since some here are also maintainer there. Can you please clarify which one is correct?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmcauliffe is the maintainer for both. My understanding is that MIT is the correct license.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmcauliffe Can you please confirm this?

In that case the license should be license: MIT OR other_licencse

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/conch_sounds, recipes/polyglotdb, recipes/pyraat) and found some lint.

Here's what I've got...

For recipes/polyglotdb:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/conch_sounds, recipes/polyglotdb, recipes/pyraat) and found it was in an excellent condition.

@michaelhaaf
Copy link
Author

@conda-forge/staged-recipes I believe the changes requested have been addressed. thanks for the feedback!

@michaelhaaf michaelhaaf requested a review from BastianZim March 15, 2022 01:31
Copy link
Member

@BastianZim BastianZim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments then this is ready.

build:
number: 0
script: {{ PYTHON }} -m pip install . -vv
noarch: python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be removed until MontrealCorpusTools/PolyglotDB#167 is available.

Suggested change
noarch: python

Co-authored-by: Bastian Zimmermann <10774221+BastianZim@users.noreply.github.com>
@stale
Copy link

stale bot commented Aug 13, 2022

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

@stale stale bot added the stale will be closed in 30 days label Aug 13, 2022
@stale
Copy link

stale bot commented Sep 20, 2022

Hi again! About a month ago, we commented on this PR saying it would be closed in another month if it was still inactive. It has been a month and so now it is being closed. Thank you so much for making it in the first place and contributing to the community project that is conda-forge. If you'd like to reopen this PR, please feel free to do so at any time!

Cheers and have a great day!

@stale stale bot closed this Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

staged-recipes stale will be closed in 30 days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants