added test for test_route53_domains_privacy_protection_enabled #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Adding unit tests for the route53_domains_privacy_protection_enabled check to verify proper detection of missing privacy protection on Route 53 domains.
Description
Added a comprehensive test suite for the route53_domains_privacy_protection_enabled check.
-Test scenarios include:
-No Route53 domains exist
-All domains have privacy protection enabled
-Some domains are missing specific privacy protection roles
-get_domain_detail fails with a ClientError
-list_domains fails with a BotoCoreError
Checklist
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.