Add Unit Tests for cloudtrail_cloudwatch_logging_enabled Check #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) | ||
| report = self.check.execute(self.mock_session) | ||
| assert report.status == CheckStatus.UNKNOWN | ||
| assert report.resource_ids_status[0].summary == "Error retrieving CloudTrail details." |
Contributor
There was a problem hiding this comment.
Your test test_cloudwatch_logging_enabled has only the log group ARN but not the role ARN, so it's incorrectly expected to pass.
Add a test case with both compliant and non-compliant trails to validate cumulative status logic (FAILED if any fail).
aafaq-rashid-comprinno
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces unit test coverage for the
cloudtrail_cloudwatch_logging_enabledcheck, ensuring its behavior is validated across multiple CloudTrail trail configurations.Description
These tests confirm the check's response when:
TestCloudTrailCloudWatchLoggingEnabledChecklist
cloudtrail_cloudwatch_logging_enabledLicense
I confirm that my contribution is made under the terms of the Apache 2.0 license.