Extract common signing steps to an action#1058
Open
mhegazy wants to merge 3 commits intocompnerd:mainfrom
Open
Extract common signing steps to an action#1058mhegazy wants to merge 3 commits intocompnerd:mainfrom
mhegazy wants to merge 3 commits intocompnerd:mainfrom
Conversation
sundresh
approved these changes
Nov 30, 2025
Collaborator
sundresh
left a comment
sundresh
left a comment
There was a problem hiding this comment.
I like the deduplication here.
Looking at this PR, I also see a lot of duplication in the msbuild steps. It might be worth factoring that out later (not asking for it in this PR), although I'm not sure if the calls would end up just as long in order to pass in all of the arguments from the calling context.
Collaborator
mhegazy
force-pushed
the
upstream-refactor-signing
branch
from
6464026 to
5958c82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signing steps are duplicated between 4 jobs now. extract them to an action to avoid duplication.
downstream job without signing: https://github.com/thebrowsercompany/swift-build/actions/runs/19777383994
downstream jobs with signing: https://github.com/thebrowsercompany/swift-build/actions/runs/19774595404
downstream 6.3 job: https://github.com/thebrowsercompany/swift-build/actions/runs/19804026228/job/56735897976