Skip to content

Conversation

@miunau
Copy link
Contributor

@miunau miunau commented Aug 18, 2025

this exports types needed to get into the internals properly, and adds .js extensions to imports so they are nodenext compatible. without them, installing this into an eg. sveltekit project will have type errors in the ide

@brettz9
Copy link
Contributor

brettz9 commented Sep 7, 2025

@Gregoor This would be nice to have reviewed if you have some time since the use of exports disallows reaching into the package for types.

Copy link
Collaborator

@Gregoor Gregoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I always thought it's better to export fewer types since changing types would be API breakage (aka major version bump) but I suppose it's not as simple as I believed. Let's do it!

@Gregoor Gregoor merged commit 4c3ff42 into commonbaseapp:main Sep 17, 2025
5 checks passed
@brettz9
Copy link
Contributor

brettz9 commented Sep 17, 2025

Hi,

I'm not sure if you have completed the full release process yet (including npm), but I noticed the new release 0.20.1 on GitHub is well behind the latest published version number 4.0.0 per https://www.npmjs.com/package/zodex?activeTab=versions . (I also don't see 0.20.1 on npm.)

@Gregoor
Copy link
Collaborator

Gregoor commented Sep 17, 2025

yeah I was also surprised to see the github releases going, but our auto publish to NPM is still not fixed, so I'll manually do a 4.0.1 release

@Gregoor
Copy link
Collaborator

Gregoor commented Sep 17, 2025

4.0.1 has been published

@miunau
Copy link
Contributor Author

miunau commented Sep 17, 2025

Huh, I always thought it's better to export fewer types since changing types would be API breakage (aka major version bump) but I suppose it's not as simple as I believed. Let's do it!

I think anyone going into internal types will expect breakage so it's not a big deal. Thanks for taking care of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants