Zod4 update #50
Merged
Zod4 update #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettz9
force-pushed
the
zod4-work
branch
4 times, most recently
from
5639aca to
669cec8
Compare
Contributor
|
I've done some stuff to make the TS build work, I'll make a PR to your repo |
Contributor
Author
|
Awesome! I realized I still needed to add a few of the new features, now added, except for template literals which I hope to add in another commit as I am able. |
Contributor
Author
|
Ok, done now... |
Contributor
Author
|
Ok, thanks to @miunau 's invaluable help, I think we're ready for a review... If prettier 3 noise is an issue, I can revert to 2 for now. |
brettz9
force-pushed
the
zod4-work
branch
8 times, most recently
from
3119ae9 to
544aca1
Compare
brettz9
force-pushed
the
zod4-work
branch
3 times, most recently
from
e1a8e2b to
fbba09c
Compare
brettz9
force-pushed
the
zod4-work
branch
9 times, most recently
from
b029b13 to
e2ec3bf
Compare
Collaborator
|
As always, thank you for your great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49 .
I applied prettier update fixes in the last 2 commits, though I can undo those. The meat of the PR is in the first commit.
TypeScript is not entirely passing, however, and I'm not clear on how to fix the remaining issues.