Skip to content

feat: all cards #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
adrienzheng-cb wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

feat: all cards #329

adrienzheng-cb wants to merge 13 commits into from

Conversation

@adrienzheng-cb
Copy link
Contributor

@adrienzheng-cb adrienzheng-cb commented Jan 26, 2026 •
edited
Loading

What changed? Why?

Root cause (required for bugfixes)

UI changes

https://cds-storybook.coinbase.com/?path=/story/components-cells-contentcell--with-accessory
https://cds-docs.netlify.app/

Testing

How has it been tested?

  • Unit tests
  • Interaction tests
  • Pseudo State tests
  • Manual - Web
  • Manual - Android (Emulator / Device)
  • Manual - iOS (Emulator / Device)

Testing instructions

Illustrations/Icons Checklist

Required if this PR changes files under packages/illustrations/** or packages/icons/**

  • verified visreg changes with Terran (include link to visreg run/approval)
  • all illustration/icons names have been reviewed by Dom and/or Terran

Change management

type=routine
risk=low
impact=sev5

automerge=false

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 26, 2026 •
edited
Loading

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 1
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1
CODEOWNERS 🟡 See below

🟡 CODEOWNERS

Code Owner Status Calculation
ui-systems-eng-team 🟡 0/1
Denominator calculation
Additional CODEOWNERS Requirement
Show calculation
Sum 0
0
From CODEOWNERS 1
Sum 1

@adrienzheng-cb adrienzheng-cb requested a review from hcopp January 29, 2026 04:48
cb-ekuersch
cb-ekuersch reviewed Jan 29, 2026
View reviewed changes
apps/docs/docs/components/cards/ContainedAssetCard/mobileMetadata.json Outdated
@@ -2,11 +2,12 @@
"import": "import { ContainedAssetCard } from '@coinbase/cds-mobile/cards/ContainedAssetCard'",
"source": "https://github.com/coinbase/cds/blob/master/packages/mobile/src/cards/ContainedAssetCard.tsx",
"figma": "https://www.figma.com/design/k5CtyJccNQUGMI5bI4lJ2g/%E2%9C%A8-CDS-Components?node-id=10084-2760&t=DIcYU9WAXkBUimkN-0",
Copy link
Contributor

@cb-ekuersch cb-ekuersch Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please take this opportunity tomake sure the figma urls point to the correct component and that the linked node is the actual component/component set node

cb-ekuersch
cb-ekuersch reviewed Jan 29, 2026
View reviewed changes
apps/docs/docs/components/cards/DataCard/mobileMetadata.json
{
"import": "import { DataCard } from '@coinbase/cds-mobile/alpha/data-card'",
"source": "https://github.com/coinbase/cds/blob/master/packages/mobile/src/alpha/data-card/DataCard.tsx",
"description": "A flexible card component for displaying data with visualizations like progress bars and circles. It supports horizontal and vertical layouts with customizable thumbnails and title accessories.",
Copy link
Contributor

@cb-ekuersch cb-ekuersch Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

figma link?

Copy link
Contributor Author

@adrienzheng-cb adrienzheng-cb Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have the link to figma yet for the new components. need to wait until design merge their figma branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cb-ekuersch cb-ekuersch cb-ekuersch left review comments

@hcopp hcopp Awaiting requested review from hcopp

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

apps:docs apps:mobile-app packages:mobile packages:mobile-visualization packages:ui-mobile-playground packages:ui-mobile-visreg packages:web packages:web-visualization

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adrienzheng-cb @cb-heimdall @cb-ekuersch