feat: ContentCard #244
Open
feat: ContentCard #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrienzheng-cb
force-pushed
the
adrien/data-card
branch
2 times, most recently
from
0faa084 to
3746651
Compare
adrienzheng-cb
force-pushed
the
adrien/content-card
branch
from
7241bac to
c64a939
Compare
adrienzheng-cb
force-pushed
the
adrien/data-card
branch
from
3746651 to
a5e53aa
Compare
adrienzheng-cb
force-pushed
the
adrien/content-card
branch
2 times, most recently
from
08b7d41 to
c9ab6cd
Compare
adrienzheng-cb
force-pushed
the
adrien/data-card
branch
2 times, most recently
from
5cae302 to
f93bbc2
Compare
adrienzheng-cb
force-pushed
the
adrien/data-card
branch
from
f93bbc2 to
d72f1a1
Compare
adrienzheng-cb
force-pushed
the
adrien/content-card
branch
3 times, most recently
from
adf6f3d to
34c4fc0
Compare
adrienzheng-cb
force-pushed
the
adrien/data-card
branch
from
d72f1a1 to
3b8e08d
Compare
adrienzheng-cb
force-pushed
the
adrien/content-card
branch
from
34c4fc0 to
6f22d53
Compare
adrienzheng-cb
force-pushed
the
adrien/data-card
branch
from
3b8e08d to
d45dbeb
Compare
adrienzheng-cb
force-pushed
the
adrien/content-card
branch
from
6f22d53 to
713ff47
Compare
cb-ekuersch
reviewed
Jan 26, 2026
Contributor
cb-ekuersch
left a comment
cb-ekuersch
left a comment
There was a problem hiding this comment.
Nice job keeping things bw compatible here!
| import { Pressable, type PressableProps } from '../../system'; | ||
|
|
||
| export type ContentCardBaseProps = VStackProps; | ||
| export type ContentCardBaseProps = PressableProps & { |
Contributor
There was a problem hiding this comment.
the types look off here. We should only assign base props to base props
| */ | ||
| body?: React.ReactNode; | ||
| /** Use for supplemental data */ | ||
| description?: React.ReactNode; |
|
|
||
| export type ContentCardBodyBaseProps = SharedProps & { | ||
| /** Main body copy */ | ||
| title?: React.ReactNode; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Root cause (required for bugfixes)
UI changes
docs
storybook
Testing
How has it been tested?
Testing instructions
Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false