Skip to content

Conversation

@shreypdev
Copy link

@shreypdev shreypdev commented Nov 10, 2025

What changed? Why?

Consumer apps migrating to React Native's new architecture experienced broken chart scrubbing due to an outdated version of react-native-gesture-handler.

Changes:

  • Upgrade react-native-gesture-handler: 2.16.2 → 2.24.0
  • Add useEvent mock for test compatibility
  • Remove unused patch file

PR with new arch #153

Why this bump is required

We encountered an issue where gesture handlers such as <GestureDetector gesture={longPressGesture}> were not correctly recognized or triggered on apps using the React Native New Architecture (Fabric) when using version 2.16.2. After upgrading to 2.24.0, gestures started working correctly under the new architecture.

Technical Reason

  • Full Fabric support (React Native New Architecture) began in versions after 2.3.0, but many critical bug fixes and improvements were introduced after 2.16.2 and up to 2.24.0.
  • The core fixes include major refactors in gesture detector internals, virtual detectors, and root view management to support Fabric.

Root cause (required for bugfixes)

UI changes

iOS Old iOS New
old screenshot new screenshot
Android Old Android New
old screenshot new screenshot
Web Old Web New
old screenshot new screenshot

Testing

How has it been tested?

  • Unit tests
  • Interaction tests
  • Pseudo State tests
  • Manual - Web
  • Manual - Android (Emulator / Device)
  • Manual - iOS (Emulator / Device)

Testing instructions

Change management

type=routine
risk=low
impact=sev5

automerge=false

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Nov 10, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 1
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2
CODEOWNERS ✅ None for this change

@cb-heimdall
Copy link
Collaborator

Review Error for LoganClark835 @ 2025-11-11 03:34:54 UTC
User failed mfa authentication, either user does not exist or public email is not set on your github profile. \ see go/mfa-help

@shreypdev shreypdev closed this Nov 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants