Class Generation Updates & Updated to 679#9
Open
eigenben wants to merge 4 commits intocodyfauser:masterfrom
Open
Class Generation Updates & Updated to 679#9eigenben wants to merge 4 commits intocodyfauser:masterfrom
eigenben wants to merge 4 commits intocodyfauser:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to get a more modern API version running and was running into serious issues getting the classes generated. Looks like a lot of it relied on old versions of libxml-ruby and other gems. I think I've got this all figured out in commit d7124d5 and I certainly did get it updated to version 679 and all appears well in the rather large app I have which is using this project.
If I have some time I might hack on this some more to get it working with Rails 3 and using a Gemfile to manage the messy dependencies per http://github.com/radar/guides/blob/master/gem-development.md.
I believe a few people have already started to use my branch due to the updates so thought I'd send you a pull request. Try it out (I think there might even be a new API version out you can try to update to as well) and merge if you feel appropriate.
Thanks for all your work on this project, it has helped me a great deal.