-
Notifications
You must be signed in to change notification settings - Fork 0
Add Schedule Page Containing Timetable (Issue #3) #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…just width and height properly, added resizeAndPositionTimetableTasks, added onScroll and resize listeners for this function
…timetable tasks, added a current time indicator
…automatic scroll and resize on load to improve user experience
… overlap with a multiple tasks timetableTask
…here is more visible area to the left of the task
…llow more customisation of time display mode
…l screen to meet deadline easier
|
I'm happy with the code in general, and from your demonstrations I've seen it working well (aside from the remaining bugs you've already mentioned). I just want to check my understanding of your structure to ensure I get what your section is doing:
|
|
Basically right, I'll go through and add some documentation to the components and add some docs at the top of each file to explain what's contained in. |
|
Okay, that's good. I'm happy to merge this now :) |
Change Summary
Change Form
Remaining Bugs (Minor)
Other
Related issue